[PATCH 4/5] nvmet: relocate the cntlid_ida to the internal of subsystem

Guixin Liu kanie at linux.alibaba.com
Wed Dec 13 04:59:26 PST 2023


在 2023/12/13 16:46, Christoph Hellwig 写道:
> On Wed, Dec 13, 2023 at 02:32:51PM +0800, Guixin Liu wrote:
>> As per the NVMe specification, the cntlid must be unique within an NVM
>> subsystem. Therefore, the cntlid_ida should be moved internally within
>> the subsystem.
> Sagi added this with a commit log of:
>
> "
> nvmet: Make cntlid globally unique
>      
> We usually log the cntlid which is confusing in case
> we have multiple subsystems each with it's own cntlid ida.
> Instead make cntlid ida globally unique and log the initial
> association.
> "
>
> which seems reasonable.  If you have a reason for not making it unique,
> it needs to be stated here so we can weight it against the original
> reason for making the ids globally unique.

Emm, I just change this per the NVMe spec, Sagi's comment is reasonable.




More information about the Linux-nvme mailing list