[PATCH 5/5] nvmet: return invalid filed when check fctype fails

Sagi Grimberg sagi at grimberg.me
Wed Dec 13 05:52:41 PST 2023


>>> Return invalid filed status code when check fctype fails in
>>> nvmet_parse_connect_cmd().
>> Hmm, the fabrics command type really is part of the opcode.  What is the
>> reason for you to prefer one error over the other?
>>
>> Also s/filed/field/g or better 'Invalid Field in Command'
> Agree, by the way, should return invalid opcode in 
> nvmet_rdma_map_sgl_inline() if nvme_is_write() check fails?

I think that in that case the invalid part is the sgl, not the
opcode.



More information about the Linux-nvme mailing list