[PATCH 5/5] nvmet: return invalid filed when check fctype fails

Guixin Liu kanie at linux.alibaba.com
Wed Dec 13 05:05:59 PST 2023


在 2023/12/13 16:48, Christoph Hellwig 写道:
> On Wed, Dec 13, 2023 at 02:32:52PM +0800, Guixin Liu wrote:
>> Return invalid filed status code when check fctype fails in
>> nvmet_parse_connect_cmd().
> Hmm, the fabrics command type really is part of the opcode.  What is the
> reason for you to prefer one error over the other?
>
> Also s/filed/field/g or better 'Invalid Field in Command'
Agree, by the way, should return invalid opcode in 
nvmet_rdma_map_sgl_inline() if nvme_is_write() check fails?



More information about the Linux-nvme mailing list