[RFC v0] nvme: do not log errors for user commands

[Daniel Wagner]

On Thu, Sep 29, 2022 at 12:51:21PM -0600, Keith Busch wrote:
> On Thu, Sep 29, 2022 at 07:13:37PM +0200, Daniel Wagner wrote:
> > @@ -325,6 +325,9 @@ static void nvme_log_error(struct request *req)
> >  		return;
> >  	}
> >  
> > +	if (nr->flags & NVME_REQ_USERCMD)
> > +		return;
> > +
> 
> It would be more consistent with existing usage to set RQF_QUIET in the
> request's rq_flags before dispatching if we wanted to suppress user space admin
> command errors. If we did that, though, there are no more admin queue users for
> the verbose logging since internally generated commands already set RQF_QUIET.

I've tried to find a way how we could pass a quiet flag from user
land. I don't see how to add this flag on the existing IOCTL
APIs except by adding a new IOCTL like NVME_IOCTL_SET_CONFIG or so.

In my books this new logging infrastructure bd83fe6f2cd2 ("nvme: add
verbose error logging") is causing a regression. Thus I would like to
suggest we add the RQF_QUIET flag to the admin passthrough commands as
well and let those who are interested in the additional logging
figuring out a solution.