[RFC v0] nvme: do not log errors for user commands

Keith Busch kbusch at kernel.org
Thu Sep 29 11:51:21 PDT 2022


On Thu, Sep 29, 2022 at 07:13:37PM +0200, Daniel Wagner wrote:
> @@ -325,6 +325,9 @@ static void nvme_log_error(struct request *req)
>  		return;
>  	}
>  
> +	if (nr->flags & NVME_REQ_USERCMD)
> +		return;
> +

It would be more consistent with existing usage to set RQF_QUIET in the
request's rq_flags before dispatching if we wanted to suppress user space admin
command errors. If we did that, though, there are no more admin queue users for
the verbose logging since internally generated commands already set RQF_QUIET.



More information about the Linux-nvme mailing list