[PATCH v2 2/3] nvme/multipath: cosmetic: keep ns nsid locally

[Christoph Hellwig]

On Mon, Sep 13, 2021 at 01:57:17PM -0700, Keith Busch wrote:
> > > I can't really see any improvement here.  Also checkpath as so often
> > > these days is fundamentally wrong here.
> > 
> > Do we you prefer to scrap this commit?
> > 
> > I just wanted to get rid of multiple occurances of "ns->head->ns_id",
> > and just use a local variable that only changes
> > once in the for_each iteration.
> 
> I personally think "unsigned" is a well defined type in C and we should
> ignore check-patch complaints on its use.

Agreed.  If we want to cleanup nsids (and at this point I don't), we
should move them all over to u32 instead..

> Otherwise, I don't have a
> problem with the patch.

Well, it is obviously correct, but I also don't see the point of it.