[PATCH v2 2/3] nvme/multipath: cosmetic: keep ns nsid locally

[Keith Busch]

On Mon, Sep 13, 2021 at 02:19:35PM -0600, Anton Eidelman wrote:
> On Mon, Sep 13, 2021 at 06:02:20PM +0200, Christoph Hellwig wrote:
> > On Mon, Sep 13, 2021 at 09:30:22AM -0600, Anton Eidelman wrote:
> > > Keep the nsid of the current namespace in a local variable.
> > > Change the type to unsigned int to make checkpatch happy.
> > > 
> > > Signed-off-by: Anton Eidelman <anton at lightbitslabs.com>
> > 
> > I can't really see any improvement here.  Also checkpath as so often
> > these days is fundamentally wrong here.
> 
> Do we you prefer to scrap this commit?
> 
> I just wanted to get rid of multiple occurances of "ns->head->ns_id",
> and just use a local variable that only changes
> once in the for_each iteration.

I personally think "unsigned" is a well defined type in C and we should
ignore check-patch complaints on its use. Otherwise, I don't have a
problem with the patch.