[PATCHv3] nvme-mpath: delete disk after last connection

[Hannes Reinecke]

On 5/4/21 10:54 AM, Christoph Hellwig wrote:
> As stated in the v3 review this is an incompatible change.  We'll need
> the queue_if_no_path attribute first, and default it to on to keep
> compatability.
> 

That is what I tried the last time, but the direction I got was to treat 
both, NVMe-PCI and NVMe-oF identically:
(https://lore.kernel.org/linux-nvme/34e5c178-8bc4-68d3-8374-fbc1b451b6e8@grimberg.me/)

 >>>> And yes, this is exactly the same setup, the only difference
 >>>> being the CMIC setting for the NVMe device.
 >>>
 >>> I agree with Christoph that we should do exactly the same for all.
 >>>
 >>> Hannes, My understanding here is that you want the device to go away
 >>> after the last path disappeared because it breaks md, why don't you
 >>> want to have this also for fabrics?
 >>>
 >> Oh, I would _love_ to have it for fabrics per default.
 >> If you agree with it I can resend Keiths original patch, which solves
 >> the issue without the need for any additional settings.
 >
 > I think that this is what we should do. Care to resend this for
 > both fabrics and pci?

So what is it now?
Should I go back to the previous patch series?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer