[PATCH V2 3/6] nvmet: remove unnecessary function parameters

Christoph Hellwig hch at lst.de
Tue Mar 9 10:00:49 GMT 2021


On Fri, Mar 05, 2021 at 02:40:34PM -0800, Sagi Grimberg wrote:
>
>> The function nvmet_ctrl_find_get() accepts subsysnqn, hostnqn, cntlid,
>> nvmet_req, and out pointer to nvmet_ctrl structure. The parameters
>> subsysnqn, hostnqn and cntlid can be derived from the caller's
>> struct nvmf_connect_data.
>>
>> Replace these parameters with structure pointer nvmf_connect_data *d.
>
> Usually its preferable to use explicit parameters instead of a wire
> transferred data structure. Not sure this particular change is useful.

Yes, I can see that point.  Especially if we want to eventually add
PCIe/vhost support.

Chaitanya, can you respin a patch to just change the return value to the
nvmet_ctrl?



More information about the Linux-nvme mailing list