[PATCH V2 3/6] nvmet: remove unnecessary function parameters

Sagi Grimberg sagi at grimberg.me
Fri Mar 5 22:40:34 GMT 2021


> The function nvmet_ctrl_find_get() accepts subsysnqn, hostnqn, cntlid,
> nvmet_req, and out pointer to nvmet_ctrl structure. The parameters
> subsysnqn, hostnqn and cntlid can be derived from the caller's
> struct nvmf_connect_data.
> 
> Replace these parameters with structure pointer nvmf_connect_data *d.

Usually its preferable to use explicit parameters instead of a wire
transferred data structure. Not sure this particular change is useful.



More information about the Linux-nvme mailing list