[PATCH] nvme: cleanup nvme_configure_apst

[Christoph Hellwig]

Any chance to get a review on this patch?

On Fri, Apr 09, 2021 at 04:49:30PM +0000, Niklas Cassel wrote:
> On Fri, Apr 09, 2021 at 11:45:24AM +0200, Christoph Hellwig wrote:
> > Remove a level of indentation from the main code implementating the table
> > search by using a goto for the APST not supported case.  Also move the
> > main comment above the function.
> > 
> > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > ---
> 
> (snip)
> 
> >  
> > +done:
> >  	ret = nvme_set_features(ctrl, NVME_FEAT_AUTO_PST, apste,
> >  				table, sizeof(*table), NULL);
> >  	if (ret)
> >  		dev_err(ctrl->device, "failed to set APST feature (%d)\n", ret);
> > -
> >  	kfree(table);
> >  	return ret;
> >  }
> 
> Since your patch includes whitespace cleanup related to apst,
> perhaps you could remove the trailing whitespace after the
> nvme_configure_apst() call (in nvme_init_ctrl_finish()) as well?
> 
> It's the only trailing whitespace that we have in all of core.c,
> and it makes my eyes flinch everytime I see it ;)
> 
> 
> Kind regards,
> Niklas---end quoted text---