[PATCH] nvme: cleanup nvme_configure_apst

Christoph Hellwig hch at lst.de
Sat Apr 10 07:50:25 BST 2021


On Fri, Apr 09, 2021 at 04:49:30PM +0000, Niklas Cassel wrote:
> >  	ret = nvme_set_features(ctrl, NVME_FEAT_AUTO_PST, apste,
> >  				table, sizeof(*table), NULL);
> >  	if (ret)
> >  		dev_err(ctrl->device, "failed to set APST feature (%d)\n", ret);
> > -
> >  	kfree(table);
> >  	return ret;
> >  }
> 
> Since your patch includes whitespace cleanup related to apst,
> perhaps you could remove the trailing whitespace after the
> nvme_configure_apst() call (in nvme_init_ctrl_finish()) as well?
> 
> It's the only trailing whitespace that we have in all of core.c,
> and it makes my eyes flinch everytime I see it ;)

Well, this patch only touches nvme_configure_apst, not any of the
callers.  But I'd gladly take a patch to clean up the trailing
whitespace from you.



More information about the Linux-nvme mailing list