[PATCH] nvme-loop: allow ctrl-loss-tmo for nvme-loop

Sagi Grimberg sagi at grimberg.me
Wed Sep 16 13:00:50 EDT 2020


>>> Update nvme-loop transport with NVMF_OPT_CTRL_LOSS_TMO in allowed ops.
>>> Without this patch following command fails on my setup :-
>>>
>>> nvme_fabrics: invalid parameter 'ctrl_loss_tmo=%d'
>>
>> But loop doesn't do anything with this param, why should it
>> accept it?
>>
> 
> With latest nvme-cli all the testcases are failing [1] with this patch
> they pass [2]. We can ignore this param in the nvme-loop unless there is
> a need for implementing the behavior.

I'd say we need to fix nvme-cli not passing optional parameters by
default...



More information about the Linux-nvme mailing list