[PATCH] nvme-loop: allow ctrl-loss-tmo for nvme-loop

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Tue Sep 15 21:30:03 EDT 2020


On 9/15/20 16:12, Sagi Grimberg wrote:
>> Update nvme-loop transport with NVMF_OPT_CTRL_LOSS_TMO in allowed ops.
>> Without this patch following command fails on my setup :-
>>
>> nvme_fabrics: invalid parameter 'ctrl_loss_tmo=%d'
> 
> But loop doesn't do anything with this param, why should it
> accept it?
> 

With latest nvme-cli all the testcases are failing [1] with this patch
they pass [2]. We can ignore this param in the nvme-loop unless there is 
a need for implementing the behavior.

[1] Failed test-cases :-

  # ./check tests/nvme/
nvme/002 (create many subsystems and test discovery)         [failed]
     runtime    ...  20.131s
     --- tests/nvme/002.out	2019-09-13 21:45:10.352000000 -0700
     +++ /root/blktests/results/nodev/nvme/002.out.bad	2020-09-15 
17:51:24.222000000 -0700
     @@ -1,3003 +1,3 @@
      Running nvme/002
     -Discovery Log Number of Records 1000, Generation counter X
     -=====Discovery Log Entry 0======
     -trtype:  loop
     -subnqn:  blktests-subsystem-0
     -=====Discovery Log Entry 1======
     -trtype:  loop
     ...
     (Run 'diff -u tests/nvme/002.out 
/root/blktests/results/nodev/nvme/002.out.bad' to see the entire diff)
nvme/003 (test if we're sending keep-alives to a discovery controller) 
[failed]
     runtime  10.136s  ...  10.104s
     --- tests/nvme/003.out	2019-09-13 21:45:10.352000000 -0700
     +++ /root/blktests/results/nodev/nvme/003.out.bad	2020-09-15 
17:51:34.526000000 -0700
     @@ -1,3 +1,4 @@
      Running nvme/003
     -NQN:nqn.2014-08.org.nvmexpress.discovery disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +NQN:nqn.2014-08.org.nvmexpress.discovery disconnected 0 controller(s)
      Test complete
nvme/004 (test nvme and nvmet UUID NS descriptors)           [failed]
     runtime  2.856s  ...  0.139s
     --- tests/nvme/004.out	2019-09-13 21:45:10.352000000 -0700
     +++ /root/blktests/results/nodev/nvme/004.out.bad	2020-09-15 
17:51:34.841000000 -0700
     @@ -1,5 +1,7 @@
      Running nvme/004
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/004.out 
/root/blktests/results/nodev/nvme/004.out.bad' to see the entire diff)
nvme/005 (reset local loopback target)                       [failed]
     runtime  3.451s  ...  0.136s
     --- tests/nvme/005.out	2019-09-13 21:45:10.352000000 -0700
     +++ /root/blktests/results/nodev/nvme/005.out.bad	2020-09-15 
17:51:35.166000000 -0700
     @@ -1,2 +1,6 @@
      Running nvme/005
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +tests/nvme/005: line 43: /sys/class/nvme//reset_controller: 
Permission denied
     +Failed to disconnect by device name:
      Test complete
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
     runtime  0.099s  ...  0.100s
nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
     runtime  0.057s  ...  0.058s
nvme/008 (create an NVMeOF host with a block device-backed ns) [failed]
     runtime  2.906s  ...  0.138s
     --- tests/nvme/008.out	2019-09-13 21:45:10.353000000 -0700
     +++ /root/blktests/results/nodev/nvme/008.out.bad	2020-09-15 
17:51:35.998000000 -0700
     @@ -1,5 +1,7 @@
      Running nvme/008
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/008.out 
/root/blktests/results/nodev/nvme/008.out.bad' to see the entire diff)
nvme/009 (create an NVMeOF host with a file-backed ns)       [failed]
     runtime  2.816s  ...  0.096s
     --- tests/nvme/009.out	2019-09-13 21:45:10.353000000 -0700
     +++ /root/blktests/results/nodev/nvme/009.out.bad	2020-09-15 
17:51:36.286000000 -0700
     @@ -1,5 +1,7 @@
      Running nvme/009
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/009.out 
/root/blktests/results/nodev/nvme/009.out.bad' to see the entire diff)
nvme/010 (run data verification fio job on NVMeOF block device-backed 
ns) [failed]
     runtime  17.964s  ...  1.678s
     --- tests/nvme/010.out	2019-09-13 21:45:10.353000000 -0700
     +++ /root/blktests/results/nodev/nvme/010.out.bad	2020-09-15 
17:51:38.228000000 -0700
     @@ -1,5 +1,12 @@
      Running nvme/010
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/010.out 
/root/blktests/results/nodev/nvme/010.out.bad' to see the entire diff)
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [failed]
     runtime  361.528s  ...  0.980s
     --- tests/nvme/011.out	2019-09-13 21:45:10.353000000 -0700
     +++ /root/blktests/results/nodev/nvme/011.out.bad	2020-09-15 
17:51:39.465000000 -0700
     @@ -1,5 +1,12 @@
      Running nvme/011
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/011.out 
/root/blktests/results/nodev/nvme/011.out.bad' to see the entire diff)
nnvme/012 (run mkfs and data verification fio job on NVMeOF block 
device-backed ns) [failed]
     runtime  41.423s  ...  19.896s
     --- tests/nvme/012.out	2019-09-13 21:45:10.354000000 -0700
     +++ /root/blktests/results/nodev/nvme/012.out.bad	2020-09-15 
17:51:59.535000000 -0700
     @@ -1,5 +1,11 @@
      Running nvme/012
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/012.out 
/root/blktests/results/nodev/nvme/012.out.bad' to see the entire diff)
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed 
ns) [failed]
     runtime  147.563s  ...  15.116s
     --- tests/nvme/013.out	2019-09-13 21:45:10.354000000 -0700
     +++ /root/blktests/results/nodev/nvme/013.out.bad	2020-09-15 
17:52:14.911000000 -0700
     @@ -1,5 +1,7 @@
      Running nvme/013
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/013.out 
/root/blktests/results/nodev/nvme/013.out.bad' to see the entire diff)
nvme/014 (flush a NVMeOF block device-backed ns)             [failed]
     runtime  21.723s  ...  10.242s
     --- tests/nvme/014.out	2019-09-13 21:45:10.354000000 -0700
     +++ /root/blktests/results/nodev/nvme/014.out.bad	2020-09-15 
17:52:25.330000000 -0700
     @@ -1,6 +1,17 @@
      Running nvme/014
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NVMe Flush: success
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     ...
     (Run 'diff -u tests/nvme/014.out 
/root/blktests/results/nodev/nvme/014.out.bad' to see the entire diff)
nvme/015 (unit test for NVMe flush for file backed ns)       [failed]
     runtime  19.574s  ...  10.089s
     --- tests/nvme/015.out	2019-09-13 21:45:10.354000000 -0700
     +++ /root/blktests/results/nodev/nvme/015.out.bad	2020-09-15 
17:52:35.606000000 -0700
     @@ -1,6 +1,17 @@
      Running nvme/015
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NVMe Flush: success
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     ...
     (Run 'diff -u tests/nvme/015.out 
/root/blktests/results/nodev/nvme/015.out.bad' to see the entire diff)
nvme/016 (create/delete many NVMeOF block device-backed ns and test 
discovery) [failed]
     runtime  14.664s  ...  14.691s
     --- tests/nvme/016.out	2019-09-13 21:45:10.354000000 -0700
     +++ /root/blktests/results/nodev/nvme/016.out.bad	2020-09-15 
17:52:50.470000000 -0700
     @@ -1,6 +1,3 @@
      Running nvme/016
     -Discovery Log Number of Records 1, Generation counter X
     -=====Discovery Log Entry 0======
     -trtype:  loop
     -subnqn:  blktests-subsystem-1
     +Failed to write to /dev/nvme-fabrics: Invalid argument
      Test complete
nvme/017 (create/delete many file-ns and test discovery)     [failed]
     runtime  14.640s  ...  14.590s
     --- tests/nvme/017.out	2019-09-13 21:45:10.355000000 -0700
     +++ /root/blktests/results/nodev/nvme/017.out.bad	2020-09-15 
17:53:05.247000000 -0700
     @@ -1,6 +1,3 @@
      Running nvme/017
     -Discovery Log Number of Records 1, Generation counter X
     -=====Discovery Log Entry 0======
     -trtype:  loop
     -subnqn:  blktests-subsystem-1
     +Failed to write to /dev/nvme-fabrics: Invalid argument
      Test complete
nvme/018 (unit test NVMe-oF out of range access on a file backend) [failed]
     runtime  2.807s  ...  0.102s
     --- tests/nvme/018.out	2019-09-13 21:45:10.355000000 -0700
     +++ /root/blktests/results/nodev/nvme/018.out.bad	2020-09-15 
17:53:05.538000000 -0700
     @@ -1,5 +1,9 @@
      Running nvme/018
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/018.out 
/root/blktests/results/nodev/nvme/018.out.bad' to see the entire diff)
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [failed]
     runtime  2.826s  ...  0.132s
     --- tests/nvme/019.out	2019-09-13 21:45:10.355000000 -0700
     +++ /root/blktests/results/nodev/nvme/019.out.bad	2020-09-15 
17:53:05.846000000 -0700
     @@ -1,6 +1,31 @@
      Running nvme/019
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NVMe DSM: success
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     ...
     (Run 'diff -u tests/nvme/019.out 
/root/blktests/results/nodev/nvme/019.out.bad' to see the entire diff)
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [failed]
     runtime  2.814s  ...  0.094s
     --- tests/nvme/020.out	2019-09-13 21:45:10.355000000 -0700
     +++ /root/blktests/results/nodev/nvme/020.out.bad	2020-09-15 
17:53:06.130000000 -0700
     @@ -1,6 +1,31 @@
      Running nvme/020
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -NVMe DSM: success
     -NQN:blktests-subsystem-1 disconnected 1 controller(s)
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     ...
     (Run 'diff -u tests/nvme/020.out 
/root/blktests/results/nodev/nvme/020.out.bad' to see the entire diff)
nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [failed]
     runtime  2.837s  ...  0.086s
     --- tests/nvme/021.out	2019-09-13 21:45:10.355000000 -0700
     +++ /root/blktests/results/nodev/nvme/021.out.bad	2020-09-15 
17:53:06.394000000 -0700
     @@ -1,4 +1,7 @@
      Running nvme/021
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/021.out 
/root/blktests/results/nodev/nvme/021.out.bad' to see the entire diff)
nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [failed]
     runtime  3.375s  ...  0.095s
     --- tests/nvme/022.out	2019-09-13 21:45:10.355000000 -0700
     +++ /root/blktests/results/nodev/nvme/022.out.bad	2020-09-15 
17:53:06.671000000 -0700
     @@ -1,4 +1,6 @@
      Running nvme/022
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/022.out 
/root/blktests/results/nodev/nvme/022.out.bad' to see the entire diff)
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [failed]
     runtime  2.844s  ...  0.132s
     --- tests/nvme/023.out	2019-09-13 21:45:10.356000000 -0700
     +++ /root/blktests/results/nodev/nvme/023.out.bad	2020-09-15 
17:53:06.978000000 -0700
     @@ -1,4 +1,6 @@
      Running nvme/023
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/023.out 
/root/blktests/results/nodev/nvme/023.out.bad' to see the entire diff)
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [failed]
     runtime  2.754s  ...  0.091s
     --- tests/nvme/024.out	2019-09-13 21:45:10.356000000 -0700
     +++ /root/blktests/results/nodev/nvme/024.out.bad	2020-09-15 
17:53:07.253000000 -0700
     @@ -1,4 +1,6 @@
      Running nvme/024
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/024.out 
/root/blktests/results/nodev/nvme/024.out.bad' to see the entire diff)
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [failed]
     runtime  2.747s  ...  0.093s
     --- tests/nvme/025.out	2019-09-13 21:45:10.356000000 -0700
     +++ /root/blktests/results/nodev/nvme/025.out.bad	2020-09-15 
17:53:07.533000000 -0700
     @@ -1,4 +1,6 @@
      Running nvme/025
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/025.out 
/root/blktests/results/nodev/nvme/025.out.bad' to see the entire diff)
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [failed]
     runtime  2.801s  ...  0.090s
     --- tests/nvme/026.out	2019-09-13 21:45:10.356000000 -0700
     +++ /root/blktests/results/nodev/nvme/026.out.bad	2020-09-15 
17:53:07.804000000 -0700
     @@ -1,4 +1,6 @@
      Running nvme/026
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/026.out 
/root/blktests/results/nodev/nvme/026.out.bad' to see the entire diff)
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [failed]
     runtime  2.787s  ...  0.090s
     --- tests/nvme/027.out	2019-09-13 21:45:10.356000000 -0700
     +++ /root/blktests/results/nodev/nvme/027.out.bad	2020-09-15 
17:53:08.071000000 -0700
     @@ -1,4 +1,6 @@
      Running nvme/027
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/027.out 
/root/blktests/results/nodev/nvme/027.out.bad' to see the entire diff)
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [failed]
     runtime  2.769s  ...  0.090s
     --- tests/nvme/028.out	2019-09-13 21:45:10.356000000 -0700
     +++ /root/blktests/results/nodev/nvme/028.out.bad	2020-09-15 
17:53:08.342000000 -0700
     @@ -1,4 +1,7 @@
      Running nvme/028
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/028.out 
/root/blktests/results/nodev/nvme/028.out.bad' to see the entire diff)
nvme/029 (test userspace IO via nvme-cli read/write interface) [failed]
     runtime  3.103s  ...  0.298s
     --- tests/nvme/029.out	2019-09-13 21:45:10.357000000 -0700
     +++ /root/blktests/results/nodev/nvme/029.out.bad	2020-09-15 
17:53:08.821000000 -0700
     @@ -1,4 +1,6 @@
      Running nvme/029
     -91fdba0d-f87b-4c25-b80f-db7be1418b9e
     -uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +cat: /sys/class/nvme/nvme*/transport: No such file or directory
     +cat: /sys/block/n1/uuid: No such file or directory
     +cat: /sys/block/n1/wwid: No such file or directory
     ...
     (Run 'diff -u tests/nvme/029.out 
/root/blktests/results/nodev/nvme/029.out.bad' to see the entire diff)
nvme/030 (ensure the discovery generation counter is updated 
appropriately) [failed]
     runtime  0.331s  ...  0.131s
     --- tests/nvme/030.out	2019-09-13 21:45:10.357000000 -0700
     +++ /root/blktests/results/nodev/nvme/030.out.bad	2020-09-15 
17:53:09.128000000 -0700
     @@ -1,2 +1,11 @@
      Running nvme/030
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +tests/nvme/030: line 25: ((: <=  : syntax error: operand expected 
(error token is "<=  ")
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +tests/nvme/030: line 25: ((: <=  : syntax error: operand expected 
(error token is "<=  ")
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     ...
     (Run 'diff -u tests/nvme/030.out 
/root/blktests/results/nodev/nvme/030.out.bad' to see the entire diff)
nvme/031 (test deletion of NVMeOF controllers immediately after setup) 
[failed]
     runtime  17.152s  ...  0.465s
     --- tests/nvme/031.out	2020-08-02 20:25:49.032000000 -0700
     +++ /root/blktests/results/nodev/nvme/031.out.bad	2020-09-15 
17:53:09.767000000 -0700
     @@ -1,2 +1,12 @@
      Running nvme/031
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     +Failed to write to /dev/nvme-fabrics: Invalid argument
     ...
     (Run 'diff -u tests/nvme/031.out 
/root/blktests/results/nodev/nvme/031.out.bad' to see the entire diff)
nvme/033 (test ANA optimized/transitioning/inaccessible support) [failed]
     runtime  84.098s  ...  18.353s
     --- tests/nvme/033.out	2020-08-02 20:29:24.865000000 -0700
     +++ /root/blktests/results/nodev/nvme/033.out.bad	2020-09-15 
17:53:28.369000000 -0700
     @@ -1,20 +1,205 @@
      Running nvme/033
     -nvme0c1n1: grpid 1 state optimized
     -nvme0c1n2: grpid 2 state inaccessible
     -nvme0c2n1: grpid 1 state inaccessible
     -nvme0c2n2: grpid 2 state optimized
     -ANA state transition
     -nvme0c1n1: grpid 1 state change
     ...
     (Run 'diff -u tests/nvme/033.out 
/root/blktests/results/nodev/nvme/033.out.bad' to see the entire diff)


2. Passed Test-cases :-

diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 0d6008cf66a2..517c93ede8dd 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -678,7 +678,10 @@ static struct nvmf_transport_ops 
nvme_loop_transport = {
         .name           = "loop",
         .module         = THIS_MODULE,
         .create_ctrl    = nvme_loop_create_ctrl,
-       .allowed_opts   = NVMF_OPT_TRADDR,
+       /*
+        * We currently ignore the CTRL_LOSS_TMO for nvme-loop.
+        */
+       .allowed_opts   = NVMF_OPT_TRADDR | NVMF_OPT_CTRL_LOSS_TMO,
  };

  static int __init nvme_loop_init_module(void)


nvme/002 (create many subsystems and test discovery)         [passed]
     runtime  20.165s  ...  20.955s
nvme/003 (test if we're sending keep-alives to a discovery controller) 
[passed]
     runtime  10.118s  ...  10.141s
nvme/004 (test nvme and nvmet UUID NS descriptors)           [passed]
     runtime  2.867s  ...  2.854s
nvme/005 (reset local loopback target)                       [passed]
     runtime  3.425s  ...  3.409s
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
     runtime  0.097s  ...  0.097s
nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
     runtime  0.050s  ...  0.054s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
     runtime  2.846s  ...  2.837s
nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
     runtime  2.798s  ...  2.762s
nvme/010 (run data verification fio job on NVMeOF block device-backed 
ns) [passed]
     runtime  30.388s  ...  26.443s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
     runtime  238.745s  ...  241.024s
nvme/012 (run mkfs and data verification fio job on NVMeOF block 
device-backed ns) [passed]
     runtime  39.890s  ...  36.863s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed 
ns) [passed]
     runtime  150.226s  ...  129.343s
nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
     runtime  22.811s  ...  22.595snvme/002 (create many subsystems and 
test discovery)         [passed]
     runtime  20.165s  ...  20.955s
nvme/003 (test if we're sending keep-alives to a discovery controller) 
[passed]
     runtime  10.118s  ...  10.141s
nvme/004 (test nvme and nvmet UUID NS descriptors)           [passed]
     runtime  2.867s  ...  2.854s
nvme/005 (reset local loopback target)                       [passed]
     runtime  3.425s  ...  3.409s
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
     runtime  0.097s  ...  0.097s
nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
     runtime  0.050s  ...  0.054s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
     runtime  2.846s  ...  2.837s
nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
     runtime  2.798s  ...  2.762s
nvme/010 (run data verification fio job on NVMeOF block device-backed 
ns) [passed]
     runtime  30.388s  ...  26.443s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
     runtime  238.745s  ...  241.024s
nvme/012 (run mkfs and data verification fio job on NVMeOF block 
device-backed ns) [passed]
     runtime  39.890s  ...  36.863s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed 
ns) [passed]
     runtime  150.226s  ...  129.343s
nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
     runtime  22.811s  ...  22.595s
nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
     runtime  20.756s  ...  22.266s
nvme/016 (create/delete many NVMeOF block device-backed ns and test 
discovery) [passed]
     runtime  14.594s  ...  14.685s
nvme/017 (create/delete many file-ns and test discovery)     [passed]
     runtime  14.626s  ...  14.593s
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
     runtime  2.791s  ...  2.832s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
     runtime  2.861s  ...  2.896s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
     runtime  2.803s  ...  2.820s
nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
     runtime  2.798s  ...  2.803s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
     runtime  3.400s  ...  3.420s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
     runtime  2.894s  ...  2.858s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
     runtime  2.806s  ...  2.814s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
     runtime  2.822s  ...  2.814s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
     runtime  2.767s  ...  2.810s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
     runtime  2.875s  ...  2.812s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
     runtime  2.752s  ...  2.774s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
     runtime  3.045s  ...  3.070s
nvme/030 (ensure the discovery generation counter is updated 
appropriately) [passed]
     runtime  0.324s  ...  0.327s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) 
[passed]
     runtime  17.458s  ...  17.345s

nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
     runtime  20.756s  ...  22.266s
nvme/016 (create/delete many NVMeOF block device-backed ns and test 
discovery) [passed]
     runtime  14.594s  ...  14.685s
nvme/017 (create/delete many file-ns and test discovery)     [passed]
     runtime  14.626s  ...  14.593s
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
     runtime  2.791s  ...  2.832s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
     runtime  2.861s  ...  2.896s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
     runtime  2.803s  ...  2.820s
nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
     runtime  2.798s  ...  2.803s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
     runtime  3.400s  ...  3.420s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
     runtime  2.894s  ...  2.858s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
     runtime  2.806s  ...  2.814s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
     runtime  2.822s  ...  2.814s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
     runtime  2.767s  ...  2.810s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
     runtime  2.875s  ...  2.812s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
     runtime  2.752s  ...  2.774s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
     runtime  3.045s  ...  3.070s
nvme/030 (ensure the discovery generation counter is updated 
appropriately) [passed]
     runtime  0.324s  ...  0.327s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) 
[passed]
     runtime  17.458s  ...  17.345s








More information about the Linux-nvme mailing list