[PATCH v2 7/8] nvme-rdma: fix timeout handler

Sagi Grimberg sagi at grimberg.me
Tue Aug 18 20:26:24 EDT 2020


>>>> +++ b/drivers/nvme/host/rdma.c
>>>> @@ -1185,6 +1185,7 @@ static void nvme_rdma_error_recovery(struct 
>>>> nvme_rdma_ctrl *ctrl)
>>>>       if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_RESETTING))
>>>>           return;
>>>>   +    dev_warn(ctrl->ctrl.device, "starting error recovery\n");
>>>
>>> Should this really be a warning?  I'd turn this down to _info.
>>
>> I can do that. but given that this is a fix, I'll to do that
>> as a separate patch.
> 
> I've found the impacts of the error_recovery/ctrl reset on aborting ios 
> to be a significant event, and as it should be happening rarely, it was 
> much better to put it as a warning than as an info.

We already log a warning in the timeout handler. I can keep it as is,
pretty indifferent about it.



More information about the Linux-nvme mailing list