[PATCH v2 7/8] nvme-rdma: fix timeout handler

James Smart james.smart at broadcom.com
Fri Aug 14 19:19:28 EDT 2020



On 8/14/2020 12:14 AM, Sagi Grimberg wrote:
>
>>> +++ b/drivers/nvme/host/rdma.c
>>> @@ -1185,6 +1185,7 @@ static void nvme_rdma_error_recovery(struct 
>>> nvme_rdma_ctrl *ctrl)
>>>       if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_RESETTING))
>>>           return;
>>>   +    dev_warn(ctrl->ctrl.device, "starting error recovery\n");
>>
>> Should this really be a warning?  I'd turn this down to _info.
>
> I can do that. but given that this is a fix, I'll to do that
> as a separate patch.

I've found the impacts of the error_recovery/ctrl reset on aborting ios 
to be a significant event, and as it should be happening rarely, it was 
much better to put it as a warning than as an info.

-- james




More information about the Linux-nvme mailing list