[PATCH] nvmet: Change error code of discard command if not supported
Israel Rukshin
israelr at mellanox.com
Mon Jan 29 06:00:50 PST 2018
Execute discard command on block device that doesn't support it
should return not supported error.
Returning internal error while using multi-path fails the path.
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
Signed-off-by: Israel Rukshin <israelr at mellanox.com>
---
drivers/nvme/target/io-cmd.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/target/io-cmd.c b/drivers/nvme/target/io-cmd.c
index 0a4372a..00d4607a 100644
--- a/drivers/nvme/target/io-cmd.c
+++ b/drivers/nvme/target/io-cmd.c
@@ -105,10 +105,15 @@ static void nvmet_execute_flush(struct nvmet_req *req)
static u16 nvmet_discard_range(struct nvmet_ns *ns,
struct nvme_dsm_range *range, struct bio **bio)
{
- if (__blkdev_issue_discard(ns->bdev,
+ int ret;
+
+ ret = __blkdev_issue_discard(ns->bdev,
le64_to_cpu(range->slba) << (ns->blksize_shift - 9),
le32_to_cpu(range->nlb) << (ns->blksize_shift - 9),
- GFP_KERNEL, 0, bio))
+ GFP_KERNEL, 0, bio);
+ if (ret == -EOPNOTSUPP)
+ return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
+ else if (ret)
return NVME_SC_INTERNAL | NVME_SC_DNR;
return 0;
}
--
1.8.3.1
More information about the Linux-nvme
mailing list