[PATCH 0/2] nvme-fc: io termination cleanup

James Smart james.smart at broadcom.com
Mon Feb 12 08:28:25 PST 2018


Looks good.  I was more interested in the blk-mq resource busy addition 
that was merged as well. it looks fine too, but I'll need to test it a bit.

Thanks

-- james


On 2/11/2018 12:48 AM, Sagi Grimberg wrote:
>
>> The patches address io termination issues in nvme-fc:
>>
>> The first patch addresses a race condition on io termination vs
>> reset/delete abort paths that allowed an io to complete yet the
>> association termination counted it and is waiting for the completion.
>>
>> The second patch addresses cleanup of the code that was synchronizing
>> io termination between the lldd done path and the blk-mq completion
>> path. the completion path existed because, at the time, the eh_handler
>> could return a successful return status, allowing the complete routine
>> to be called, although the io was still active in the lldd. Since then
>> the eh_handler has been corrected to reschedule the io timer after
>> initiating the abort and this condition is no longer true.
>
> Hi James,
>
> Picked up for 4.16-rc, had a slight conflict due to Max's ctrl state
> change. Please verify its ok.
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme




More information about the Linux-nvme mailing list