[PATCH 2/2] nvme-rdma: give up reconnect if state change fails

Sagi Grimberg sagi at grimberg.me
Wed Sep 20 04:29:18 PDT 2017


>>   	changed = nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_LIVE);
>> -	WARN_ON_ONCE(!changed);
>> +	if (!changed) {
>> +		/* We are probably in DELETING state */
> 
> Shouldn't we check if we're really in DELETING instead of just speculating we
> are?

I can add a WARN_ONCE.



More information about the Linux-nvme mailing list