[PATCH 2/2] nvme-rdma: give up reconnect if state change fails

[Johannes Thumshirn]

On Wed, Sep 20, 2017 at 02:06:13PM +0300, Sagi Grimberg wrote:
>  	changed = nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_LIVE);
> -	WARN_ON_ONCE(!changed);
> +	if (!changed) {
> +		/* We are probably in DELETING state */

Shouldn't we check if we're really in DELETING instead of just speculating we
are?

Byte,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850