[PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure

Sagi Grimberg sagi at grimberg.me
Thu Oct 19 03:28:42 PDT 2017


>>> to be allocated instead of the admin flag?A  E.g.:
>>>
>>> 	error = nvme_rdma_alloc_tagset(&ctrl->ctrl, &ctrl->ctrl.admin_tagset);
>>> 	if (error)
>>> 		goto out_free_queue;
>>
>> We could, but that would mean that the nvme_ctrl tagset pointer will
>> need to be updated later (or from the routine itself).
> 
> That why I want to pass the address of the tagset pointers, so that
> it can be updated.

But I'm targeting this code to nvme-core which at this point, only has
a pointer to the tagsets (which are embedded in the transport ctrl
structs).



More information about the Linux-nvme mailing list