[PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure

Christoph Hellwig hch at lst.de
Thu Oct 19 03:20:22 PDT 2017


>> Can we return an error code instead and just pass in the tag set
>> to be allocated instead of the admin flag?A  E.g.:
>>
>> 	error = nvme_rdma_alloc_tagset(&ctrl->ctrl, &ctrl->ctrl.admin_tagset);
>> 	if (error)
>> 		goto out_free_queue;
>
> We could, but that would mean that the nvme_ctrl tagset pointer will
> need to be updated later (or from the routine itself).

That why I want to pass the address of the tagset pointers, so that
it can be updated.



More information about the Linux-nvme mailing list