[PATCH 1/2] nvme-loop: retrieve iod from the cqe command_id

Sagi Grimberg sagi at grimberg.me
Tue Feb 28 06:25:31 PST 2017


>> useful to validate that the we didn't mess up
>> the command_id.
>
> But also less efficient, so I don't really see a good reason for it.

Less efficient? I highly doubt this will ever make any noticeable
difference...

I changed that because the blk-mq scheduler facilities broke nvmf and
it took me a while to figure out why loop doesn't break like rdma, but
I really don't see why we do something different from all other
transports, especially since its main usage is testing...

I can drop it if you insist against it but I sorta disagree with
you.



More information about the Linux-nvme mailing list