[PATCHv2 1/2] nvme-rdma: move nvme cm status helper to .h file

Bart Van Assche Bart.VanAssche at sandisk.com
Mon Feb 20 09:03:15 PST 2017


On 02/20/2017 03:44 AM, Max Gurtovoy wrote:
> This will enable the usage for nvme rdma target.
> Also move from a lookup array to a switch statement.

Hello Max,

In general un-inlining code that is not in the hot path is wrong because
this increases the size of the kernel and because this increases the
time needed to build the kernel. Would it have been possible to keep the
nvme_rdma_cm_msg() definition in a .c file?

Thanks,

Bart.



More information about the Linux-nvme mailing list