[PATCH] nvmet: Avoid writing fabric_ops, queue pointers on every request.

Parav Pandit parav at mellanox.com
Wed Feb 15 08:31:00 PST 2017



> -----Original Message-----
> From: Sagi Grimberg [mailto:sagi at grimberg.me]
> Sent: Wednesday, February 15, 2017 10:29 AM
> To: hch at lst.de
> Cc: Parav Pandit <parav at mellanox.com>; james.smart at broadcom.com;
> linux-nvme at lists.infradead.org
> Subject: Re: [PATCH] nvmet: Avoid writing fabric_ops, queue pointers on
> every request.
> 
> 
> >> Yep, forgot that the sq/cq are referenced from the rsp which is
> >> per-queue.
> >>
> >> Christoph, James, can I get an ack from you guys?
> >
> > I really hate the nvmet_req_fabric_ops_init and
> > nvmet_req_link_to_nvme_queues helpers, just use direct assignments
> > instead of trivial helpers with crazy long names.
> 
> Heh, I don't mind it all that much, but we can hold it off until something
> better (if at all) comes along..

How about 
nvmet_ops_init()
nvmet_link_queues()




More information about the Linux-nvme mailing list