[PATCH 2/5] nvme/pci: Cancel work after watchdog disabled

Johannes Thumshirn jthumshirn at suse.de
Mon Feb 13 02:25:31 PST 2017


On 02/11/2017 12:15 AM, Keith Busch wrote:
> The driver had been flushing the work prior to uninitializing the
> controller, hoping the work would not get restarted. If controller
> failure or IO time occurs when tearing down the request queues, the
> watchdog timer may queue another reset.
> 
> We want to make sure that reset work is not running to prevent use after
> free errors accessing the device being torn down, so this patch cancels
> the reset work only after we know it can never be started again.
> 
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---

Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>


-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



More information about the Linux-nvme mailing list