[PATCH v2 1/4] MicroSemi Switchtec management interface driver

Greg Kroah-Hartman gregkh at linuxfoundation.org
Fri Feb 10 06:51:24 PST 2017


On Thu, Feb 02, 2017 at 11:06:00AM -0700, Logan Gunthorpe wrote:
> +	cdev = &stdev->cdev;
> +	cdev_init(cdev, &switchtec_fops);
> +	cdev->owner = THIS_MODULE;
> +	cdev->kobj.parent = &dev->kobj;

Minor nit, the kobject in a cdev is unlike any other kobject you have
ever seen, don't mess with it, it's not doing anything like you think it
is doing.  So no need to set the parent field.

thanks,

greg k-h



More information about the Linux-nvme mailing list