[PATCH v3 0/2] nvme: APST support
Andy Lutomirski
luto at kernel.org
Fri Feb 3 13:44:36 PST 2017
As far as I can tell, APST works fine on every NVMe device I'm aware
of with the single exception of a particular Samsung device. This
series enables APST by default but quirks it off on the offending
Samsung device. Some Samsung engineers are taking a look, and,
depending on what they find, we may be able to change the quirk to
work around the bug rather than disabling APST outright.
I think it would be nice to queue this up for 4.11.
Changes from v2:
- Remove a stray newline.
- Use switch when translating pm_qos args to latency (Christoph)
- I did *not* change the initialization sequence. If we want to do
that, can it be a followup patch?
Changes from v1:
- Fix a totally wrong comment in the quirk code (me)
- Add a comment about not redetecting quirks after reset (Keith)
- Rearrange the series to avoid bisection problems (Jens)
Once fully applied, v1 and v2 only differ in their comments.
Changes from before:
- Rebased to linux-block/for-next.
- I added a quirk for the known-bad Samsung device.
- It's fully integrated with dev_pm_qos.
- I now program APST after all the queues are set up, which seems safer.
(This didn't fix the Samsung problem, though.)
Andy Lutomirski (2):
nvme: Add a quirk mechanism that uses identify_ctrl
nvme: Enable autonomous power state transitions
drivers/nvme/host/core.c | 217 +++++++++++++++++++++++++++++++++++++++++++++++
drivers/nvme/host/nvme.h | 13 +++
drivers/nvme/host/pci.c | 2 +
drivers/nvme/host/rdma.c | 2 +
include/linux/nvme.h | 6 ++
5 files changed, 240 insertions(+)
--
2.9.3
More information about the Linux-nvme
mailing list