[PATCH v3] nvme-rdma: support devices with queue size < 32

[Marta Rybczynska]

----- Le 20 Avr 17, à 13:43, Sagi Grimberg sagi at grimberg.me a écrit :

>> Looks good,
>>
>> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
>>
>> BTW, did you test with deeper queue depths (say 512)?

It's in progress. Small depth (16) is running for several
days already.

> 
> Wait, taking it back...
> 
> Can you make nvme_rdma_queue_sig_limit() return a bool instead?

Sure.

> 
> Also, Looking at this closer, I'm pretty convinced that this
> should convert to atomic. For iSER its fine as is because
> we are under the iscsi connection lock, but here we need to
> handle mutual exclusion.
> 
> This would be an incremental change though.

I can see that. I was wondering about atomics when rewriting
this, and I agree that it will be cleaner.

Marta