[PATCH v3] nvme-rdma: support devices with queue size < 32

Sagi Grimberg sagi at grimberg.me
Thu Apr 20 04:43:27 PDT 2017


> Looks good,
>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
>
> BTW, did you test with deeper queue depths (say 512)?

Wait, taking it back...

Can you make nvme_rdma_queue_sig_limit() return a bool instead?

Also, Looking at this closer, I'm pretty convinced that this
should convert to atomic. For iSER its fine as is because
we are under the iscsi connection lock, but here we need to
handle mutual exclusion.

This would be an incremental change though.



More information about the Linux-nvme mailing list