[PATCH, RFC] nvme: Do not test the read-ahead flag in cmd_flags

Jens Axboe axboe at fb.com
Wed Sep 14 07:43:48 PDT 2016


On 09/14/2016 08:23 AM, Christoph Hellwig wrote:
> On Wed, Sep 14, 2016 at 12:02:22PM +0200, Bart Van Assche wrote:
>> REQ_RAHEAD is a bio-only flag (bio.bi_opf) and hence is never set in
>> request.cmd_flags. Hence remove the cmd_flags & REQ_RAHEAD tests.
>> Compile-tested only.
>
> It's indeed a bug, but the questions is if why we shouldn't pass
> REQ_RAHEAD down to the request layer.  It's a useful attribute,
> and NVMe devices could make use of it.

Indeed, seems a shame to lose this hint.


-- 
Jens Axboe




More information about the Linux-nvme mailing list