[PATCH, RFC] nvme: Do not test the read-ahead flag in cmd_flags

Christoph Hellwig hch at lst.de
Wed Sep 14 07:23:06 PDT 2016


On Wed, Sep 14, 2016 at 12:02:22PM +0200, Bart Van Assche wrote:
> REQ_RAHEAD is a bio-only flag (bio.bi_opf) and hence is never set in
> request.cmd_flags. Hence remove the cmd_flags & REQ_RAHEAD tests.
> Compile-tested only.

It's indeed a bug, but the questions is if why we shouldn't pass
REQ_RAHEAD down to the request layer.  It's a useful attribute,
and NVMe devices could make use of it.



More information about the Linux-nvme mailing list