[PATCH v2 6/7] SRP transport: Port srp_wait_for_queuecommand() to scsi-mq

Christoph Hellwig hch at lst.de
Tue Oct 11 09:44:17 PDT 2016


On Wed, Oct 05, 2016 at 02:51:50PM -0700, Bart Van Assche wrote:
> There are multiple direct blk_*() calls in other SCSI transport drivers. So 
> my proposal is to wait with moving this code into scsi_lib.c until there is 
> a second user of this code.

I still don't think these low-level difference for blk-mq vs legacy
request belong into a scsi LLDD.  So I concur with Sagi that this
should go into the core SCSI code.

In fact I suspect we should just call it directly from
scsi_internal_device_block, and maybe even scsi_internal_device_unblock
for case of setting the device offline.



More information about the Linux-nvme mailing list