[PATCH rfc 5/6] nvme-pci: open-code polling logic in nvme_poll

Johannes Thumshirn jthumshirn at suse.de
Wed Oct 5 06:52:37 PDT 2016

On Wed, Oct 05, 2016 at 12:42:13PM +0300, Sagi Grimberg wrote:
> Given that the code is simple enough it seems better
> then passing a tag by reference for each call site.
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
>  drivers/nvme/host/pci.c | 36 +++++++++++++++++++++---------------
>  1 file changed, 21 insertions(+), 15 deletions(-)

I don't really see how the call by value vs. call by reference change is a
better trade-off than open coding __nvme_process_cq(), as we'd have to
duplicate any possible fix for this function then (yes I see it's quite
simple but I have some doubt it's 100% bugfree).

Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

More information about the Linux-nvme mailing list