[PATCH] nvme-cli: fabrics: remove libudev dependency

Keith Busch keith.busch at intel.com
Fri Dec 16 07:27:04 PST 2016


On Fri, Dec 16, 2016 at 12:04:19AM -0800, Christoph Hellwig wrote:
> We can have multiple controllers with the same nqn, and they should all
> be deleted with this option.  Also I think factoring the removal code
> in the inner block into a separate function would make this a bit more
> readable.

I also noticed that the description for the 'nqn' field is LIST, but
we're not splitting that item. Was this supposed to be a comma separated
value of nqn's?

Thanks for the other comments; I'll fix those up.



More information about the Linux-nvme mailing list