[PATCH v6 5/7] nvme-fabrics: Add host support for FC transport

Johannes Thumshirn jthumshirn at suse.de
Fri Dec 2 06:17:07 PST 2016


On Fri, Dec 02, 2016 at 03:13:33PM +0100, Christoph Hellwig wrote:
> On Fri, Dec 02, 2016 at 09:55:31AM +0100, Johannes Thumshirn wrote:
> > ^^ there's a stray newline, someone should probably fix this up when applying.
> > > +	 *    be "in order" for the nvme layer. As the nvme layer in
> > > +	 *    linux doesn't care about sqhd, there's no need to return
> > > +	 *    them in order.
> 
> I think the whole comment is a little overblown as we don't even pass the
> CQE up anymore.  I've just fixed up the empty line for now, though.
> 
> > Jens, Keith, Sagi, Christoph, how are the chances to get this in for v4.10?
> 
> I've applied the patches after editing the changelogs and pushed the code
> out to the nvmf-4.10 branch.  But I'd really like a promise from James
> that we'll get working controller reset code in the next weeks before
> we're sending the code on to Jens.

Sounds good to me.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



More information about the Linux-nvme mailing list