[PATCH 4/4] mtd: spi-nand: winbond: Sort the devices
Miquel Raynal
miquel.raynal at bootlin.com
Mon May 18 02:56:02 PDT 2026
On 18/05/2026 at 18:17:18 +09, Dominique MARTINET <dominique.martinet at atmark-techno.com> wrote:
> Miquel Raynal wrote on Wed, Oct 09, 2024 at 02:50:02PM +0200:
>> Use alphabetical order, not because it's pretty, but because it makes
>> sense. This way the devices are listed by density, and then by hardware
>> feature set. Add comments to make the list more understandable.
>>
>> There is no intended functional change.
>
> Probably won't matter for most people, but FWIW this commit added
> W25N04KW, and thus was not only a re-order (I assume sorting made you
> notice it was missing, but forgot to split it out)
>
> This has the side-effect that this particular nand won't work on stable
> trees (device additions are usually backported to recent kernels), but
> I'm not sure it's worth the effort to send a stable patch just for that,
> I just wanted to point it out in case someone else searchs for this string
> or 6.12 kernels or older:
> spi-nand spi0.0: unknown raw ID efba230000
>
>
> $ git show 25f643a3d73ff9f559339dba6ac35bedd8f8e4f6 | rg '^[+-][ \t]*SPINAND_INFO\(' | sort
[...]
> + SPINAND_INFO("W25N04KW", /* 1.8V */
Crap. Indeed I don't think it's a bit problem, but yeah, sorry for
missing this, it should have been split.
Thanks,
Miquèl
More information about the linux-mtd
mailing list