[PATCH 4/4] mtd: spi-nand: winbond: Sort the devices
Dominique MARTINET
dominique.martinet at atmark-techno.com
Mon May 18 02:17:18 PDT 2026
Miquel Raynal wrote on Wed, Oct 09, 2024 at 02:50:02PM +0200:
> Use alphabetical order, not because it's pretty, but because it makes
> sense. This way the devices are listed by density, and then by hardware
> feature set. Add comments to make the list more understandable.
>
> There is no intended functional change.
Probably won't matter for most people, but FWIW this commit added
W25N04KW, and thus was not only a re-order (I assume sorting made you
notice it was missing, but forgot to split it out)
This has the side-effect that this particular nand won't work on stable
trees (device additions are usually backported to recent kernels), but
I'm not sure it's worth the effort to send a stable patch just for that,
I just wanted to point it out in case someone else searchs for this string
or 6.12 kernels or older:
spi-nand spi0.0: unknown raw ID efba230000
$ git show 25f643a3d73ff9f559339dba6ac35bedd8f8e4f6 | rg '^[+-][ \t]*SPINAND_INFO\(' | sort
- SPINAND_INFO("W25M02GV",
+ SPINAND_INFO("W25M02GV", /* 2x1G-bit 3.3V */
- SPINAND_INFO("W25N01GV",
+ SPINAND_INFO("W25N01GV", /* 3.3V */
- SPINAND_INFO("W25N01GW",
+ SPINAND_INFO("W25N01GW", /* 1.8V */
- SPINAND_INFO("W25N01JW",
+ SPINAND_INFO("W25N01JW", /* high-speed 1.8V */
- SPINAND_INFO("W25N01KV",
+ SPINAND_INFO("W25N01KV", /* 3.3V */
- SPINAND_INFO("W25N02JW",
+ SPINAND_INFO("W25N02JW", /* high-speed 1.8V */
- SPINAND_INFO("W25N02KV",
+ SPINAND_INFO("W25N02KV", /* 3.3V */
- SPINAND_INFO("W25N02KW",
+ SPINAND_INFO("W25N02KW", /* 1.8V */
- SPINAND_INFO("W25N04KV",
+ SPINAND_INFO("W25N04KV", /* 3.3V */
+ SPINAND_INFO("W25N04KW", /* 1.8V */
- SPINAND_INFO("W25N512GW",
+ SPINAND_INFO("W25N512GW", /* 1.8V */
That aside, backporting this spinand info appears to work.
Thanks,
--
Dominique
More information about the linux-mtd
mailing list