[PATCH v2] mtd: spi-nor: Rename spi_nor_spimem_check_op()
Miquel Raynal
miquel.raynal at bootlin.com
Tue Mar 17 06:21:08 PDT 2026
On 17/03/2026 at 10:46:49 GMT, Pratyush Yadav <pratyush at kernel.org> wrote:
> On Tue, Mar 17 2026, Miquel Raynal wrote:
>
>> This helper really is just a little helper for internal purposes, and is
>> I/O operation oriented, despite its name. It has already been misused
>> in commit 5008c3ec3f89 ("mtd: spi-nor: core: Check read CR support"), so
>> rename it to clarify its purpose: it is only useful for reads and page
>> programs.
>>
>> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
>
> Reviewed-by: Pratyush Yadav <pratyush at kernel.org>
>
> This one is tricky. It won't compile without "mtd: spi-nor: Fix RDCR
> controller capability core check". So to take it through spi-nor/next, I
> would need to rebase the branch on the -rc in which the RDCR patch [0]
> lands.
I forgot it was only applicable after the other patch. In general, you
are welcome to directly merge the relevant -rc in spi-nor/next, no need
for mtd/next to be based on it too. But for this specific case, if you
agree I will take it through the fixes branch directly. They are related
anyway (after renaming it _read_pp_op() as suggested by Tudor).
Thanks,
Miquèl
More information about the linux-mtd
mailing list