[PATCH v2] mtd: spi-nor: Rename spi_nor_spimem_check_op()

Pratyush Yadav pratyush at kernel.org
Tue Mar 17 03:46:49 PDT 2026


On Tue, Mar 17 2026, Miquel Raynal wrote:

> This helper really is just a little helper for internal purposes, and is
> I/O operation oriented, despite its name. It has already been misused
> in commit 5008c3ec3f89 ("mtd: spi-nor: core: Check read CR support"), so
> rename it to clarify its purpose: it is only useful for reads and page
> programs.
>
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>

Reviewed-by: Pratyush Yadav <pratyush at kernel.org>

This one is tricky. It won't compile without "mtd: spi-nor: Fix RDCR
controller capability core check". So to take it through spi-nor/next, I
would need to rebase the branch on the -rc in which the RDCR patch [0]
lands.

And while I don't think it is necessary, the history will be a bit
cleaner if mtd/next is also based on that -rc. No strong preferences
about that though.

Does this sound good to you or is there a better way of handling this?

[0] https://lore.kernel.org/linux-mtd/20260317101842.319656-1-miquel.raynal@bootlin.com/T/#u

[...]

-- 
Regards,
Pratyush Yadav



More information about the linux-mtd mailing list