[PATCH 1/2] mtd: spinand: Introduce a way to avoid raw access

[Miquel Raynal]

Hi,

On 31/10/2024 at 11:21:54 +09, tkuw584924 at gmail.com wrote:

> From: Takahiro Kuwano <Takahiro.Kuwano at infineon.com>
>
> SkyHigh spinand device has ECC enable bit in configuration register but
> it must be always enabled. If ECC is disabled, read and write ops
> results in undetermined state. For such devices, a way to avoid raw
> access is needed.
>
> Introduce SPINAND_NO_RAW_ACCESS flag to advertise the device does not
> support raw access. Read and write page in raw mode for the device
> returns error.
>
> Checking and marking BBM need to be performed with ECC enabled to read
> and write the BBM correctly.

I see your point but I'm a bit puzzled by how it's being done.

First, you disregard completely the isbad() and markbad()
situations. Please have look into that because these functions are
broken with your devices.

Second, what about adding this detail to the ondie ECC engine? You could
simply return an error from there, so basically a single (or maybe two)
changes overall.

Thanks,
Miquèl