[PATCH mtd-utils v2 RESEND 000/102] Add fsck.ubifs support

[Zhihao Cheng]

在 2024/11/11 17:52, David Oberhollenzer 写道:
> Hi,
> 
> I'm sorry for the long wait. I had your RFC patch set applied locally
> and at one point even pulled your updated version from gitee.com. As you
> noticed, I cherry-picked some of the fixes for the last mtd-utils release,
> hoping to get around to reviewing the rest that mostly adds features
> afterwards.
> 
> Due to the sheer size of this and the previous patch set, I only reviewed
> small parts of it at at time, always post poning the rest back "for later"
> which ended up constantly slipping further away.
> 

Hi, David. Very happy to be awared of the progress for the fsck.ubifs 
pacthes. I know you and Richard are busy men, and fsck.ubifs is a big 
work, so I admit that it does take a long time to review those patches.
And I'm happy to answer any questions about the code/designment.

> I think by now I've managed to look into all of the RFC set in several
> sittings and IMO that looked good so far. We even did some limited testing
> with broken UBIFS images as well.
> 
> I applied your v2 patches and did a diff against my local branch with the
> previous version. From what I can tell, the diff is quite small. Besides
> autoconf plumbing for ASAN support, the changes seem to be mostly cosmetic.

Yes, there are only a few differences between v1->v2, and most of them 
are spelling mistakes and code optimizations.
> 
> If nobody else has any objections, I would like to *finally* push this to
> upstream mtd-utils.

*Notice*, in patch 97(tests: ubifs_tools: fsck_tests: Add corrupted 
images), patchwork[1] doesn't contain the content of file 
tests/ubifs_tools-tests/images/xinode_mode.gz, please reference to lore[2].
Anyway, after that, I will do a comparison between it and the version on 
my local machine, and then let you kwnow whether the patches are applied 
correctly.

[1] 
https://patchwork.ozlabs.org/project/linux-mtd/patch/20241111090832.2093596-28-chengzhihao1@huawei.com/
[2] 
https://lore.kernel.org/linux-mtd/20241111090832.2093596-28-chengzhihao1@huawei.com/T/#u
> 
> P.S. I typed this up ~1.5 hours ago as a response to the v2 patch set. I 
> held
> of sending, when the RESEND (and resend attempt?) came in. The git-diff 
> from
> the RESEND to the v2 I had already applied is indeed empty, so that should
> be fine.

Yes, the content of v2 and 'v2 RESEND' is same.
> 
> Greetings,
> 
> David
> .