[PATCH mtd-utils v2 RESEND 000/102] Add fsck.ubifs support

David Oberhollenzer david.oberhollenzer at sigma-star.at
Mon Nov 11 01:52:40 PST 2024


Hi,

I'm sorry for the long wait. I had your RFC patch set applied locally
and at one point even pulled your updated version from gitee.com. As you
noticed, I cherry-picked some of the fixes for the last mtd-utils release,
hoping to get around to reviewing the rest that mostly adds features
afterwards.

Due to the sheer size of this and the previous patch set, I only reviewed
small parts of it at at time, always post poning the rest back "for later"
which ended up constantly slipping further away.

I think by now I've managed to look into all of the RFC set in several
sittings and IMO that looked good so far. We even did some limited testing
with broken UBIFS images as well.

I applied your v2 patches and did a diff against my local branch with the
previous version. From what I can tell, the diff is quite small. Besides
autoconf plumbing for ASAN support, the changes seem to be mostly cosmetic.

If nobody else has any objections, I would like to *finally* push this to
upstream mtd-utils.

P.S. I typed this up ~1.5 hours ago as a response to the v2 patch set. I held
of sending, when the RESEND (and resend attempt?) came in. The git-diff from
the RESEND to the v2 I had already applied is indeed empty, so that should
be fine.

Greetings,

David



More information about the linux-mtd mailing list