[PATCH v5 3/6] mtd: spi-nor: core: Allow specifying the byte order in DTR mode

liao jaime jaimeliao.tw at gmail.com
Tue Nov 21 01:53:02 PST 2023


Hi Michael

>
> Hi,
>
> > +static inline bool spi_nor_is_octal_dtr_swab16(const struct spi_nor
> > *nor,
> > +                                             enum spi_nor_protocol proto)
> > +{
> > +     return (proto == SNOR_PROTO_8_8_8_DTR) &&
> > +             (nor->flags & SNOR_F_DTR_SWAB16);
> > +}
>
> I think you can keep this code, but SNOR_F_DTR_SWAB16 only makes sense
> for
> SNOR_PROTO_8_8_8_DTR, because this is the only protocol where one clock
> cycle transfers more than 8 bit. Are there any other use cases?
No, as I know 8_8_8_DTR swapped byte only.

>
> -michael
Thanks
Jaime



More information about the linux-mtd mailing list