[PATCH v5 3/6] mtd: spi-nor: core: Allow specifying the byte order in DTR mode

Michael Walle michael at walle.cc
Tue Nov 21 00:40:13 PST 2023


Hi,

> +static inline bool spi_nor_is_octal_dtr_swab16(const struct spi_nor 
> *nor,
> +						enum spi_nor_protocol proto)
> +{
> +	return (proto == SNOR_PROTO_8_8_8_DTR) &&
> +		(nor->flags & SNOR_F_DTR_SWAB16);
> +}

I think you can keep this code, but SNOR_F_DTR_SWAB16 only makes sense 
for
SNOR_PROTO_8_8_8_DTR, because this is the only protocol where one clock
cycle transfers more than 8 bit. Are there any other use cases?

-michael



More information about the linux-mtd mailing list