[PATCH] mtd: spi-nor: fix minmax.cocci warnings

Vignesh Raghavendra vigneshr at ti.com
Sun Mar 27 22:58:30 PDT 2022


Hi.

On 26/03/22 2:00 pm, Julia Lawall wrote:
> From: kernel test robot <lkp at intel.com>
> 
> Use min to simplify the code.
> 
> Generated by: scripts/coccinelle/misc/minmax.cocci
> 
> Fixes: 2747bc2106aa ("mtd: spi-nor: Add dual parallel and stacked mode support")
> CC: Amit Kumar Mahapatra <amit.kumar-mahapatra at xilinx.com>
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Julia Lawall <julia.lawall at inria.fr>
> ---
> 
> tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
> head:   1870e0fa79a9d58c6748c34550f3ccea0b515933
> commit: 2747bc2106aa429773d9a932c799aa6229595148 [840/1029] mtd: spi-nor: Add dual parallel and stacked mode support
> :::::: branch date: 34 hours ago
> :::::: commit date: 8 weeks ago
> 
>  drivers/mtd/spi-nor/core.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2034,10 +2034,7 @@ static int spi_nor_read(struct mtd_info
>  						(offset << nor->shift);
>  			}
>  		}
> -		if (len < rem_bank_len)
> -			read_len = len;
> -		else
> -			read_len = rem_bank_len;
> +		read_len = min(len, rem_bank_len);

This chunk does not exist in mainline. Seems like xlnx local changes.

Regards
Vignesh



More information about the linux-mtd mailing list