[PATCH 2/2] mtd: spi-nor: macronix: Use post_bfpt hook to fix quad_enable method for MX25L12835F

Michael Walle michael at walle.cc
Tue Mar 1 06:41:49 PST 2022


Am 2022-03-01 10:56, schrieb Tudor Ambarus:
> MX25L12835F does not define BFPT[DWORD(15)], update the quad_enable 
> method
> in a post_bfpt hook.
> 
> Reported-by: Heiko Thiery <heiko.thiery at gmail.com>
> Signed-off-by: Tudor Ambarus <tudor.ambarus at microchip.com>
> ---
>  drivers/mtd/spi-nor/macronix.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/macronix.c 
> b/drivers/mtd/spi-nor/macronix.c
> index 3d0e34c9410c..20fab9814b80 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -37,6 +37,9 @@ static int mx25l12805d_post_bfpt_fixups(struct 
> spi_nor *nor,
>  	 */
>  	nor->name = "mx25l12835f";
> 
> +	/* BFPT lacks information about the Quad Enable method, set it here. 
> */
> +	nor->params->quad_enable = spi_nor_sr1_bit6_quad_enable;

btw. this flash has this bit as non-volatile. I don't know if is a
good idea to enable 4-4-4 on this flash.

Does anyone know if the SFDP will give us enough information so
we know whether the QE bit is volatile or not? I had a quick look
and cannot find anything in particular.

-michael



More information about the linux-mtd mailing list