[PATCH v12 3/6] mtd: spi-nor: spansion: Rename local macros

Takahiro Kuwano tkuw584924 at gmail.com
Thu Apr 21 01:00:30 PDT 2022


On 4/21/2022 4:37 PM, Tudor.Ambarus at microchip.com wrote:
> On 4/21/22 09:40, tkuw584924 at gmail.com wrote:
>> -#define SPINOR_OP_CLSR         0x30    /* Clear status register 1 */
> 
> This is a legacy spansion op. So you end up with "spansion" flashes that
> use "cypress" ops, which is confusing. At the same time I don't care
Agree. Will use SPANSION_NOR_ for CLSR.

> about the name, but if you want to change it, I suggest to change all the
> defines and get rid of the "spansion" name if that's what you want.
> The driver name has to be changed as well.
> Other thought is that cypress was acquired by infineon, so what will we
> do in few years? Will we rename all macros and methods to contain infineon?
> 
No, we should keep using legacy names.

> Let us know your thoughts and if you do this kind of change, explain why.
> 
> Cheers,
> ta
Thanks,
Takahiro



More information about the linux-mtd mailing list