[PATCH v3 3/3] mtd: spi-nor: Favor the BFPT-parsed set_4byte_addr_mode method

[Pratyush Yadav]

On 14/04/22 09:32AM, Tudor.Ambarus at microchip.com wrote:
> On 4/14/22 12:21, Michael Walle wrote:
> >> +static void macronix_nor_late_init(struct spi_nor *nor)
> >> +{
> >> +     if (!nor->params->set_4byte_addr_mode)
> >> +             nor->params->set_4byte_addr_mode =
> >> +                     spi_nor_set_4byte_addr_mode_en4b_ex4b;
> > 
> > This is more of a general question. Can we have this in one
> > line? IMHO this looks awful and since linux nowadays relaxed the
> > 80 chars rule a bit and we have such long names.. I think it makes
> > sense to allow some lines to be longer than 80 chars.
> 
> I still split my terminal in multiple windows and pretty much read
> code in a 80 chars limit. But I won't argue with you, it seems you
> care about it, so I'll change it.

FWIW, I do the same. I won't like it much if line lengths get too long. 
I won't take any sides here though, either should be fine as long as the 
result at least fits in 100 chars.

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.