[PATCH] mtd: rawnand: cafe: Fix a resource leak in the error handling path of 'cafe_nand_probe()'

Miquel Raynal miquel.raynal at bootlin.com
Mon Aug 23 01:59:04 PDT 2021


Hi Christophe,

+ML

Marion et Christophe JAILLET <christophe.jaillet at wanadoo.fr> wrote on
Mon, 23 Aug 2021 10:48:39 +0200 (CEST):

> Hi,
> 
> just noticed a typo in my patch : s/our/out/ in the label 
> 
> Can you fix it before it leaves your tree?

Yep, done!

> 
> CJ
> 
>  
> 
>  
> 
> > Message du 23/08/21 10:35
> > De : "Miquel Raynal" 
> > A : "Christophe JAILLET" , miquel.raynal at bootlin.com, richard at nod.at, vigneshr at ti.com, boris.brezillon at collabora.com, lee.jones at linaro.org, segher at kernel.crashing.org, dwmw2 at infradead.org
> > Copie à : linux-mtd at lists.infradead.org, linux-kernel at vger.kernel.org, kernel-janitors at vger.kernel.org
> > Objet : Re: [PATCH] mtd: rawnand: cafe: Fix a resource leak in the error handling path of 'cafe_nand_probe()'
> > 
> > On Sat, 2021-08-21 at 07:58:45 UTC, Christophe JAILLET wrote:  
> > > A successful 'init_rs_non_canonical()' call should be balanced by a
> > > corresponding 'free_rs()' call in the error handling path of the probe, as
> > > already done in the remove function.
> > > 
> > > Update the error handling path accordingly.
> > > 
> > > Fixes: 8c61b7a7f4d4 ("[MTD] [NAND] Use rslib for CAFÉ ECC")
> > > Signed-off-by: Christophe JAILLET   
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
> > 
> > Miquel
> >  

Thanks,
Miquèl



More information about the linux-mtd mailing list